Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setindex! for MatElem with linear indexing #1407

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

lgoettgens
Copy link
Collaborator

Resolves #1406.

I furthermore moved linear indexing next to the corresponding functions for cartesian indexing.

src/Matrix.jl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #1407 (fcf3ce8) into master (e537fdd) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1407      +/-   ##
==========================================
+ Coverage   85.78%   85.80%   +0.01%     
==========================================
  Files         104      104              
  Lines       28189    28197       +8     
==========================================
+ Hits        24183    24194      +11     
+ Misses       4006     4003       -3     
Files Changed Coverage Δ
src/generic/Matrix.jl 96.66% <ø> (-0.21%) ⬇️
src/Matrix.jl 91.77% <100.00%> (-0.10%) ⬇️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thofma
Copy link
Member

thofma commented Aug 17, 2023

Merci

@thofma thofma merged commit 060bf95 into Nemocas:master Aug 18, 2023
14 of 15 checks passed
@lgoettgens lgoettgens deleted the lg/linear-index branch August 18, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linear indexing for MatElems
2 participants